[mythtv-commits] Ticket #5286: Fix initial database creation

[MythTV]

#5286: Fix initial database creation
----------------------------------------------+-----------------------------
 Reporter:  sphery <mtdean at thirdcontact.com>  |       Owner:  ijr    
     Type:  patch                             |      Status:  new    
 Priority:  minor                             |   Milestone:  unknown
Component:  mythtv                            |     Version:  head   
 Severity:  medium                            |     Mlocked:  0      
----------------------------------------------+-----------------------------
 In current trunk, initial database creation is broken.  This ticket will
 contain patches to fix the issues.

 The root of the problem was the addition of
 CompareTVDatabaseSchemaVersion() in [15902].  Its addition caused the
 default value used for a nonexistent DBSchemaVer setting to change,
 rendering invalid many of the checks for a "new database."

 The settings cache remembers the default value requested by the first
 function to call Get*Setting() for a particular setting if the value does
 not exist in the cache or in the database.

 CompareTVDatabaseSchemaVersion() uses GetNumSetting(), whereas previously
 the first function to request the DBSchemaVer used GetSetting().  Both
 simply used the default default value ("" for GetSetting() and 0 for
 GetNumSetting()), so the default value for a non-existent DBSchemaVer has
 changed from "" to 0/"0".

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5286>
MythTV <http://www.mythtv.org/>
MythTV