[mythtv-commits] Ticket #4925: Title: internal dvd player: mytharchive mp2 audio playback issues

[MythTV]

#4925: Title: internal dvd player: mytharchive mp2  audio playback issues
----------------------+-----------------------------------------------------
 Reporter:  skamithi  |       Owner:  ijr       
     Type:  defect    |      Status:  new       
 Priority:  minor     |   Milestone:  unknown   
Component:  mythtv    |     Version:  0.21-fixes
 Severity:  medium    |     Mlocked:  0         
----------------------+-----------------------------------------------------
 This issue was identified by John Pilkington and posted in #2797.

 if I issue ffmpeg -i on a mytharchive dvd I created about 1 year ago i get

 {{{Stream #0.0[0x1e0]: Video: mpeg2video, yuv420p, 720x576, 9000 kb/s,
 25.00 fps(r)}}}
   {{{Stream #0.1[0x80]: Audio: liba52, 48000 Hz, stereo, 448 kb/s}}}
   {{{Stream #0.2[0x1c0]: Audio: mp2 }}}

 The 2nd audio stream has no sample rate info. I wonder if this is a ffmpeg
 bug ?

 attached patch does 2 things:

 a) change the location AFD::RemoveAudioStreams is activated. This function
 cleans up the stream contexts so stale audio stream entries are removed
 from the list. new location is in AFD::ScanStreams and is activated only
 when the DVD encounters the AUDIO_STREAM_CHANGE event.

 b)set the sample rate default to 48000hz if sample_rate is 0 but channels
 are detected. this change is only activated for DVD playback. This 2nd
 change can be removed if the sample rate issue
 is a bug and is cleared up at some point.


 attached patch resolves the issue. testing it for a couple of weeks to
 ensure it doesn't break dvd playback for me.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4925>
MythTV <http://www.mythtv.org/>
MythTV