[mythtv-commits] Ticket #4838: make sure dvdcss_version always has something in it. Even if it isn't found.
MythTV
mythtv at cvs.mythtv.org
Mon Mar 3 20:59:02 UTC 2008
#4838: make sure dvdcss_version always has something in it. Even if it isn't
found.
---------------------------------------------+------------------------------
Reporter: Erik Hovland <erik at hovland.org> | Owner: ijr
Type: defect | Status: new
Priority: minor | Milestone: 0.21
Component: mythtv | Version: 0.21-fixes
Severity: low | Mlocked: 0
---------------------------------------------+------------------------------
The dvdcss_version string is extracted from the shared library. It might
fail if the symbol is not found. That is fine. But in the code:
{{{
if(dvdcss_library != NULL) {
/*
char *psz_method = getenv( "DVDCSS_METHOD" );
char *psz_verbose = getenv( "DVDCSS_VERBOSE" );
fprintf(stderr, "DVDCSS_METHOD %s\n", psz_method);
fprintf(stderr, "DVDCSS_VERBOSE %s\n", psz_verbose);
*/
fprintf(stderr, "libdvdread: Using libdvdcss version %s for DVD
access\n",
*dvdcss_version);
}}}
The dvdcss_version string might point to null and then printed out. Which
wouldn't crash. But would be garbage.
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/4838>
MythTV <http://svn.mythtv.org/trac>
MythTV
More information about the mythtv-commits
mailing list