[mythtv-commits] Ticket #5435: Incorrect Escaping of '&' in UPNP Requests

[MythTV]

#5435: Incorrect Escaping of '&' in UPNP Requests
-----------------------------------+----------------------------------------
 Reporter:  jeff at the-seiferts.com  |       Owner:  dblain    
     Type:  patch                  |      Status:  new       
 Priority:  minor                  |   Milestone:  0.21.1    
Component:  upnp                   |     Version:  0.21-fixes
 Severity:  medium                 |     Mlocked:  0         
-----------------------------------+----------------------------------------
 I was seeing this quite often in the debugging output from Mythbackend:

 2008-06-07 14:35:48.531 HTTPRequest::Encode Input :
 RecTv/0/item?ChanId=1249&StartTime=2008-04-23T22:00:00 2008-06-07
 14:35:48.536 HTTPRequest::Encode Output :
 RecTv/0/item?ChanId=1249&StartTime=2008-04-23T22:00:00 2008-06-07
 14:35:48.622 HTTPRequest::Encode Input : RecTv/1/key=South
 Park/item?ChanId?=1249amp;StartTime=2008-04-16T22:00:00 2008-06-07
 14:35:48.626 HTTPRequest::Encode Output : RecTv/1/key=South
 Park/item?ChanId=1249&StartTime=2008-04-16T22:00:00 2008-06-07
 14:35:48.650 HTTPRequest::Encode Input :
 RecTv/0/item?ChanId=1249&StartTime=2008-04-16T22:00:00 2008-06-07
 14:35:48.654 HTTPRequest::Encode Output :
 RecTv/0/item?ChanId=1249&StartTime=2008-04-16T22:00:00

 It seems like the HTTPRequest::Encode routing is getting called multiple
 times for the same string, and because of this, the ampersand in the
 escaped output was getting re-escaped.

 This patch was made against MythTV 0.21p17416.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5435>
MythTV <http://www.mythtv.org/>
MythTV