[mythtv-commits] mythtv commit: r17854 by paulh

mythtv at cvs.mythtv.org mythtv at cvs.mythtv.org
Fri Jul 18 09:19:20 UTC 2008


      Author: paulh
        Date: 2008-07-18 09:19:19 +0000 (Fri, 18 Jul 2008)
New Revision: 17854
   Changeset: http://cvs.mythtv.org/trac/changeset/17854

Modified:

   trunk/mythplugins/mythcontrols/mythcontrols/actionset.cpp
   trunk/mythplugins/mythcontrols/mythcontrols/actionset.h
   trunk/mythplugins/mythcontrols/mythcontrols/keybindings.cpp

Log:

Fix a segfault in MythControls when setting a keybinding.

Not sure if this is a Qt4 thing or due to a compiler change, the same code
worked in the fixes branch. The compiler complains about taking the address of
a temporary in ActionSet::GetActions() and sure enough the first time the
reference is used it segfaults.

Just changed it to return by value, a little less efficient but the list is
usually empty or contains only one value anyway.




More information about the mythtv-commits mailing list