[mythtv-commits] Ticket #4632: disabling active EIT scan breaks passive EIT gathering

[MythTV]

#4632: disabling active EIT scan breaks passive EIT gathering
--------------------+-------------------------------------------------------
 Reporter:  janne   |        Owner:  janne   
     Type:  defect  |       Status:  accepted
 Priority:  minor   |    Milestone:  0.21    
Component:  eit     |      Version:  head    
 Severity:  medium  |   Resolution:          
  Mlocked:  0       |  
--------------------+-------------------------------------------------------

Comment(by dm at prolingua.co.uk):

 I discovered a couple of bugs related to EIT handling, one of which might
 have this effect.  The attached patch fixes both.  Since I have a Nova
 T-500 I have disabled active scanning and rely on passive scanning.

 I found that passive scanning worked to begin with but changing channel,
 or perhaps only when changing multiplex, stopped it working.  I forget the
 exact cause but it was something like TVRec::TuningFrequency calls
 MPEGStreamData::SetDesiredProgram which calls MpegRecorder::Reset which
 calls _pids_listening.clear(), removing the EIT listener.  Meanwhile
 _eit_pids in DVBStreamHandler was unaffected so the EIT listener was not
 reinstated.  The fix is simply to call _eit_pids.clear() in one of the
 functions in DVBStreamHandler that get called when there is a channel
 change.

 The other fix is not critical but affects the handler of present/following
 EIT.  "Present" and "Following" are sent as different packets on the same
 PID but with different section numbers.  When a programme changes updated
 versions of each are sent and generally the same version number is used
 for the new present and new following packet.  To avoid one being lost the
 Section ID needs to be included in the version map.

 David.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4632#comment:2>
MythTV <http://svn.mythtv.org/trac>
MythTV