[mythtv-commits] Ticket #4662: Fix check for invalid dvd seek in libmythdvdnav

MythTV mythtv at cvs.mythtv.org
Thu Feb 14 00:23:20 UTC 2008


#4662: Fix check for invalid dvd seek in libmythdvdnav
---------------------------------------------+------------------------------
 Reporter:  Erik Hovland <erik at hovland.org>  |       Owner:  ijr 
     Type:  patch                            |      Status:  new 
 Priority:  minor                            |   Milestone:  0.21
Component:  mythtv                           |     Version:  head
 Severity:  low                              |     Mlocked:  0   
---------------------------------------------+------------------------------
 In the function dvdnav_sector_search in the file searching.c in
 libmythdvdnav there is a check to see if the request seek is within the
 range of the dvd. The check subtracts the offset from the length and then
 attempts to check if that value is less then zero. Both offset and length
 are unsigned integers so if offset were larger then length it would
 underflow and produce a value that is very large. Which means that the
 conditional doesn't really work as coded. To fix this we just have to
 change the conditional to see if offset is bigger then length.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4662>
MythTV <http://svn.mythtv.org/trac>
MythTV


More information about the mythtv-commits mailing list