[mythtv-commits] Ticket #4623: storage group changes for mythvideo

[MythTV]

#4623: storage group changes for mythvideo
---------------------------------------------+------------------------------
 Reporter:  George Nassas <gnassas at mac.com>  |       Owner:  ijr    
     Type:  enhancement                      |      Status:  new    
 Priority:  minor                            |   Milestone:  unknown
Component:  mythtv                           |     Version:  head   
 Severity:  medium                           |     Mlocked:  0      
---------------------------------------------+------------------------------
 This is a precursor patch for supporting storage groups from within
 mythvideo. The two main changes are:

 1) hold back edits until ::save() is called (applies to StorageGroup,
 StorageGroupEditor & StorageGroupListEditor). This is so you can
 create/edit storage groups from within a ConfigurationWizard - actions
 aren't applied until the user gets to the last panel and clicks "Finish".

 2) support programmatic create/add/delete of storage groups and storage
 group directories. The DB convert for mythvideo needs a non-GUI way to
 create and populate storage groups based on the value(s) in
 settings.VideoStartupDir.

 I also updated mythtv-setup to put up a "Save Changes?" dialog after
 groups have been edited. It looks pretty hokey. It would have been better
 to stuff StorageGroupListEditor into a ConfigurationWizard but I thought
 of it too late and am anxious to move on to the video portion of this.

 There is now a kludge argument in the StorageGroup constructor.  When the
 Init routine can't find any local dirs for a group it will fall back to
 the directories in the "Default" group. This doesn't work when creating
 new groups - your new group always picks up the "Default" dirs to start.
 The kludge argument suppresses that behaviour. Probably the fallback
 approach needs a rethink but that's for another patch.

 It wasn't clear to me if storage group directories are supposed to end
 with a /. Initially I was stripping them but non-/ storagegroup.dirname
 entries caused Very Bad Things (tm) to happen so the code strips trailing
 slashes for display and restores them for DB updates. My database has been
 updated so many times I don't know what the original values were. Just
 thought I'd mention it.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/4623>
MythTV <http://svn.mythtv.org/trac>
MythTV