[mythtv-commits] Ticket #4588: Move StorageGroup to libmyth

MythTV mythtv at cvs.mythtv.org
Mon Feb 4 23:10:29 UTC 2008

#4588: Move StorageGroup to libmyth
 Reporter:  sphery <mtdean at thirdcontact.com>  |       Owner:  ijr    
     Type:  patch                             |      Status:  new    
 Priority:  minor                             |   Milestone:  unknown
Component:  mythtv                            |     Version:  head   
 Severity:  medium                            |     Mlocked:  0      
 The attached patch, mythtv-move_storagegroup_to_libmyth.patch makes no
 functional changes to mythtv; it simply moves
 libs/libmythtv/storagegroup.{h,cpp} to libs/libmyth/storagegroup.{h,cpp}.
 Since StorageGroups will be used by plugins and since some libmyth code
 (i.e. the code for doing database backups) will be using StorageGroups, it
 makes sense for StorageGroup to be moved to libmyth.

 Note that the patch "includes" an svn rm
 libs/libmythtv/storagegroup.{h,cpp} and svn add
 libs/libmyth/storagegroup.{h,cpp} (when using svn move, the "added" file
 wouldn't show up in the diff), which should work, but is proabably worth
 verifying in your local tree before committing.  This accounts for almost
 all of the "changes" to the code (and the vast majority of the size of the
 patch.  I've also included a copy "-no_svn_remove_add" which does not move
 the files (in case you'd prefer to use svn move to move them yourself
 after applying the patch).

 The patch also fixes references to the header in #include's throughout
 mythtv.  This is why the patch touches so many files.

 Also, the patch now installs the storagegroup.h header since StorageGroups
 will be used in plugins.  Before this patch, the header was not installed.

 This probably requires a make distclean.

Ticket URL: <http://svn.mythtv.org/trac/ticket/4588>
MythTV <http://svn.mythtv.org/trac>

More information about the mythtv-commits mailing list