[mythtv-commits] Ticket #3642: "Program guide in live tv" keybinding overrides guide jump point

[MythTV]

#3642: "Program guide in live tv" keybinding overrides guide jump point
-------------------------+--------------------------------------------------
 Reporter:  anonymous    |        Owner:  cpinkham
     Type:  enhancement  |       Status:  closed  
 Priority:  minor        |    Milestone:  0.21    
Component:  mythtv       |      Version:  head    
 Severity:  medium       |   Resolution:  fixed   
  Mlocked:  0            |  
-------------------------+--------------------------------------------------

Comment(by Roo <roo.watt at gmail.com>):

 Replying to [comment:17 cpinkham]:
 > > Replying to [comment:14 cpinkham]:
 > >
 > >  * I wonder if there is a need to extend the jumppoint table with the
 extra column?
 > > Just leave the localactions defined in code, if in the future the
 local actions are
 > > changed (in code) then the db wouldn't need to be updated.
 >
 > I took this commented out code out of my patch, so the DB isn't touched.

 Cool

 > >  * If the keybinding and the jumppoint are set to different keys then
 the jumppoint
 > > still gets used, bit awkward in the setup aspect.
 >
 > I don't see this as a problem.  If the user doesn't define them both the
 same then it could lead to situations where we aren't sure what they
 actually want to do.

 Either do I really, giving the choice to users is good, having thought
 about it. I was playing devils advocate.

 > > This would have the added advantage that the local keybinding doesn't
 have to be the
 > > same as the jumppoint. Actually, there would be no need to have the
 "TV Frontend" GUIDE
 > > action bound if you have the GUIDE jumppoint set. This was one of the
 things I liked
 > > about the alternate approach.
 >
 > I considered allowing the localAction to be used if there were no keys
 bound to it, rather than requiring the key be the same as the jumppoint,
 but that will require more invasive changes because we currently don't
 have a way to lookup an action to see what actions are defined in a given
 context or what keys associate with that action.  This  is possible, we
 just don't track things this way right now.

 That was why I suggested registering the context as well as the
 localaction as a pair, thought that could be used instead.

 > The KeyContext class in mythmainwindow.cpp would have  to be modified to
 support this if you want to take a look at implementing it.  The changes
 are minor, but given the fact that localActions in question already have
 default key assignments, it would be rare for them to be empty.

 I will look into this if either, you want me to, or later if the need
 arises.

 Thanks for detailed response by the way.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3642#comment:18>
MythTV <http://svn.mythtv.org/trac>
MythTV