[mythtv-commits] Ticket #5481: PATCH: Occasional deadlock in Mainserver::ProcessRequestThread [SVN: Trunk]

[MythTV]

#5481: PATCH: Occasional deadlock in Mainserver::ProcessRequestThread [SVN: Trunk]
---------------------------------------+------------------------------------
 Reporter:  tomimo at ncircle.nullnet.fi  |        Owner:  danielk
     Type:  patch                      |       Status:  closed 
 Priority:  minor                      |    Milestone:  0.22   
Component:  mythtv                     |      Version:  head   
 Severity:  medium                     |   Resolution:  fixed  
  Mlocked:  0                          |  
---------------------------------------+------------------------------------
Changes (by danielk):

  * status:  accepted => closed
  * resolution:  => fixed


Comment:

 (In [19511]) Fixes #5481. There is in fact no deadlock, whoever wrote this
 code was very careful to only issue wakes and waits so that a
 predicative/counter was not needed. However, there was a missing
 threadPoolCond.wakeXXX() call causing an uneccesary 10 ms delay in
 handling some requests, and just to avoid a small change mucking up the
 careful orchestration I've changed the wakeOne() calls to wakeAll() calls
 which are a little more robust (however they are NOT needed for the
 current code -- it's just to protect against possible changes in Qt
 customEvent() handling causing problems in the future.)

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5481#comment:3>
MythTV <http://www.mythtv.org/>
MythTV