[mythtv-commits] Ticket #4938: second check of length is superflous

MythTV mythtv at cvs.mythtv.org
Fri Dec 26 12:32:49 UTC 2008

#4938: second check of length is superflous
 Reporter:  Erik Hovland <erik at hovland.org>  |        Owner:  ijr           
     Type:  defect                           |       Status:  infoneeded_new
 Priority:  trivial                          |    Milestone:  unknown       
Component:  mythtv                           |      Version:  head          
 Severity:  low                              |   Resolution:                
  Mlocked:  0                                |  

Comment(by dm at prolingua.co.uk):

 I've just looked back at this and found my comments on #2311 and changeset
 11598.  There's also an open ticket #5543 that is related.

 It looks as though I should have removed the references to
 NBI_VERSION_ABSENT in my patch to #2311.  The UK MHEG profile says that
 the network boot info descriptor should always have at least two bytes of
 data so the first test is there to avoid problems if an invalid descriptor
 is seen.

 This is all related to ensuring that an "off air" MHEG message is
 correctly removed when a channel comes on air.  It's also complicated,
 though, because we want to ensure that the MHEG engine does not reboot as
 a result of tuning to another channel under control of MHEG itself.

 I've made these changes in my own version and also set up recordings when
 BBC3 and UK History come on air to see exactly what happens.  I'll try and
 submit a patch with these changes if it seems to work out.


Ticket URL: <http://svn.mythtv.org/trac/ticket/4938#comment:3>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list