[mythtv-commits] Ticket #5612: bad xmltv parsing of <previously-shown>

MythTV mythtv at cvs.mythtv.org
Sun Aug 10 18:48:30 UTC 2008


#5612: bad xmltv parsing of <previously-shown>
---------------------------------+------------------------------------------
 Reporter:  soren at dalsgaards.dk  |        Owner:  stuartm
     Type:  defect               |       Status:  new    
 Priority:  minor                |    Milestone:  unknown
Component:  mythfilldatabase     |      Version:  head   
 Severity:  low                  |   Resolution:         
  Mlocked:  0                    |  
---------------------------------+------------------------------------------

Comment(by soren at dalsgaards.dk):

 {{{mythtv/programs/mythfilldatabase/xmltvparser.cpp}}} does parse the
 {{{<previously-shown>}}} tag correctly. Current code is:

 {{{
 415 else if (info.tagName() == "previously-shown")
 416 {
 417     pginfo->previouslyshown = true;
 418
 419     QString prevdate = getFirstText(info);
 420     pginfo->originalairdate = prevdate;
 421 }
 }}}

 but according to the latest DTD, which states:

 {{{
 <!ELEMENT previously-shown EMPTY>
 <!ATTLIST previously-shown start CDATA #IMPLIED
 channel CDATA #IMPLIED >
 }}}

 the code should probably read:

 {{{
 415 else if (info.tagName() == "previously-shown")
 416 {
 417     pginfo->previouslyshown = true;
 418
 419     QString prevdate = info.attribute("start");
 420     pginfo->originalairdate = prevdate;
 421 }
 }}}

 Regards, Søren

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5612#comment:1>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list