[mythtv-commits] Ticket #5195: Mythweb uses removed commfree field from channel table

[MythTV]

#5195: Mythweb uses removed commfree field from channel table
---------------------+------------------------------------------------------
 Reporter:  janne    |        Owner:  xris
     Type:  defect   |       Status:  new 
 Priority:  minor    |    Milestone:  0.22
Component:  mythweb  |      Version:  head
 Severity:  medium   |   Resolution:      
  Mlocked:  0        |  
---------------------+------------------------------------------------------

Comment(by sphery <mtdean at thirdcontact.com>):

 Simple patch modifies MythWeb's channel editor to properly set the
 commmethod to -2 when the commfree checkbox is checked.

 Rather than add a drop-down list with available commercial detection
 methods (with values as in CommercialSkipMethod in
 programs/mythfrontend/globalsettings.cpp and CommMethod in
 libs/libmythtv/channelsettings.cpp )--including "Commercial Free"--this
 simply "repurposes" the checkbox to set the appropriate value in
 commmethod.  This approach allows setting commercial free channels easily
 through the web interface.

 If the ability to set a commercial detection method through MythWeb's
 channel editor is desirable (doing so would mean maintaining proper
 synchronization of the values in 3 places throughout Myth instead of just
 2), it can be added as a new column offering all appropriate values except
 "Commercial Free."  Then, the value for the commmethod drop down would be
 used unless the commfree checkbox is checked (which would override the
 value for commmethod).

 Personally, I don't think an ability to set a per-channel commercial
 detection method through MythWeb is worth the maintenance (sync'ing values
 in 3 places).  Users wanting per-channel commercial detection methods can
 specify them through mythtv-setup's channel editor.

 This patch doesn't modify the program's usage of commfree, though--at
 first glance--that may be right as programinfo.cpp sets chancommfree based
 on the value of commmethod.  It also doesn't modify the search portion of
 MythWeb (which probably does need fixing).

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/5195#comment:1>
MythTV <http://www.mythtv.org/>
MythTV