[mythtv-commits] Ticket #3940: Segfault adding record override after viewing program details

[MythTV]

#3940: Segfault adding record override after viewing program details
-----------------------+----------------------------------------------------
 Reporter:  anonymous  |       Owner:  ijr    
     Type:  defect     |      Status:  new    
 Priority:  minor      |   Milestone:  unknown
Component:  mythtv     |     Version:  unknown
 Severity:  medium     |     Mlocked:  0      
-----------------------+----------------------------------------------------
 Sequence:
 - go to "Upcoming Recordings" page
 - view program details for an upcoming recording, then go back (hit "u",
 "ESC")
 - view recording dialog (hit "space")
 - add override (select "Don't Record" or "Add Override")

 {{{
 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread -1209124592 (LWP 23163)]
 0x004e1532 in ScheduledRecording::makeOverride (this=0x89c2de0) at
 scheduledrecording.cpp:941
 941         parentid->setValue(m_pginfo->recordid);
 }}}

 Backtrace will follow.  I believe the problem is that
 ProgramInfo::showDetails initializes "record" using loadByID, which does
 not set "record->m_pginfo".  Then, when !ApplyRecordStateChange calls
 !GetProgramRecordingStatus, "record" is left unchanged.

 This is with r14355 but the affected files seem to be unchanged in HEAD.

 The attached patch seems to fix it.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3940>
MythTV <http://svn.mythtv.org/trac>
MythTV