[mythtv-commits] Ticket #799: DTV recordings sometimes show doubled recording length

[MythTV]

#799: DTV recordings sometimes show doubled recording length
---------------------+------------------------------------------------------
 Reporter:  danielk  |        Owner:  janne   
     Type:  defect   |       Status:  assigned
 Priority:  major    |    Milestone:  0.21    
Component:  mythtv   |      Version:  head    
 Severity:  high     |   Resolution:          
  Mlocked:  0        |  
---------------------+------------------------------------------------------

Comment(by Tom Dexter <digitalaudiorock at hotmail.com>):

 For anyone interested, I was informed here:

 http://www.gossamer-threads.com/lists/mythtv/dev/293127

 ...that TV::customEvent within libs/libmythtv/tv_play.cpp calls
 NuppelVideoPlayer::SetLength() when it receives the DONE_RECORDING event
 from the recorder and sets the length to the one reported by the recorder
 (which can be incorrectly calculated).  In my specific situation (DTV
 recordings only) I found that simply commenting out that call prevents the
 double length display when recording finishes and has caused no ill
 effects that I can see:


 {{{
 void TV::customEvent(QCustomEvent *e)
 {
     if ((MythEvent::Type)(e->type()) == MythEvent::MythEventMessage)
     {
         MythEvent *me = (MythEvent *)e;
         QString message = me->Message();

         if (recorder && message.left(14) == "DONE_RECORDING")
         {
             if (GetState() == kState_WatchingRecording)
             {
                 message = message.simplifyWhiteSpace();
                 QStringList tokens = QStringList::split(" ", message);
                 int cardnum = tokens[1].toInt();
                 int filelen = tokens[2].toInt();

                 if (recorder && cardnum == recorder->GetRecorderNumber())
                 {
                     nvp->SetWatchingRecording(false);
 //                    nvp->SetLength(filelen);
                     ChangeState(kState_WatchingPreRecorded);
                 }
             }

 }}}

 This causes it to continue using the length that was calculated from the
 database and the remote encoder just prior to the end of recording.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/799#comment:27>
MythTV <http://svn.mythtv.org/trac>
MythTV