[mythtv-commits] mythtv commit: r14592 - in trunk/mythtv by danielk

[mythtv at cvs.mythtv.org]

      Author: danielk
        Date: 2007-10-02 16:23:03 +0000 (Tue, 02 Oct 2007)
New Revision: 14592
   Changeset: http://cvs.mythtv.org/trac/changeset/14592

Added:

   trunk/mythtv/libs/libmythtv/videoouttypes.h

Modified:

   trunk/mythtv/i18n/translate.pro
   trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.cpp
   trunk/mythtv/libs/libmythtv/NuppelVideoPlayer.h
   trunk/mythtv/libs/libmythtv/channel.cpp
   trunk/mythtv/libs/libmythtv/channel.h
   trunk/mythtv/libs/libmythtv/channelbase.h
   trunk/mythtv/libs/libmythtv/libmythtv.pro
   trunk/mythtv/libs/libmythtv/openglvideo.cpp
   trunk/mythtv/libs/libmythtv/openglvideo.h
   trunk/mythtv/libs/libmythtv/remoteencoder.cpp
   trunk/mythtv/libs/libmythtv/remoteencoder.h
   trunk/mythtv/libs/libmythtv/tv.cpp
   trunk/mythtv/libs/libmythtv/tv.h
   trunk/mythtv/libs/libmythtv/tv_play.cpp
   trunk/mythtv/libs/libmythtv/tv_play.h
   trunk/mythtv/libs/libmythtv/tv_rec.cpp
   trunk/mythtv/libs/libmythtv/videoout_directfb.cpp
   trunk/mythtv/libs/libmythtv/videoout_directfb.h
   trunk/mythtv/libs/libmythtv/videoout_dx.cpp
   trunk/mythtv/libs/libmythtv/videoout_dx.h
   trunk/mythtv/libs/libmythtv/videoout_ivtv.cpp
   trunk/mythtv/libs/libmythtv/videoout_null.cpp
   trunk/mythtv/libs/libmythtv/videoout_null.h
   trunk/mythtv/libs/libmythtv/videoout_quartz.cpp
   trunk/mythtv/libs/libmythtv/videoout_quartz.h
   trunk/mythtv/libs/libmythtv/videoout_xv.cpp
   trunk/mythtv/libs/libmythtv/videoout_xv.h
   trunk/mythtv/libs/libmythtv/videooutbase.cpp
   trunk/mythtv/libs/libmythtv/videooutbase.h
   trunk/mythtv/programs/mythfrontend/globalsettings.cpp

Log:

Refs #4009. Places videoout helper enums and typedefs that are used throughout MythTV in their own file videoouttypes.h.

This changeset looks bigger than it is, because this uses enums throughtout where the enums had been cast to int before.

When looking at the #4009, aspect ratio issue the other day I noticed that the translation strings for these are created in multiple places because it is not safe to include videooutbase.h everywhere. And we are also passing these around as integers and hard defining the MAX value of the enums throughout the code. The reduntant translations are error prone and the use of hard coded MAX values is dangerous when new items are added or removed from an enum.

The new videoouttypes.h has been added to the translate.pro and some strings that should have been translated before but were in files that aren't in translate.pro will now be availabe for translation.