[mythtv-commits] Ticket #4213: HDHomeRun Recording Improvements

MythTV mythtv at cvs.mythtv.org
Wed Nov 28 15:39:51 UTC 2007

#4213: HDHomeRun Recording Improvements
 Reporter:  Bill <cizek at rcn.com>  |        Owner:  danielk 
     Type:  patch                 |       Status:  reopened
 Priority:  minor                 |    Milestone:  unknown 
Component:  mythtv                |      Version:  unknown 
 Severity:  medium                |   Resolution:          
  Mlocked:  0                     |  
Changes (by Bill <cizek at rcn.com>):

  * status:  closed => reopened
  * resolution:  invalid =>



 Nick pointed out that the MSG_WAITALL flag is meaningless for UDP, so that
 part of the patch is moot.

 I took another look and found we weren't using HDRingbufferSize. This
 caused the HDHomerun's buffer to be 3-4 times smaller than the default HD
 Ring buffer.

 I attached a new patch that uses this setting for the HDHomerun buffer.

 I've included the chunksize reduction from the original patch --
 hdhomerun_video_recv returns a portion of it's internal buffer and blocks
 it from being used until the next call. This effectively reduces the
 buffer size by the amount returned. (In the original code the buffer was
 2.5 MB and we were reading .5 MB.  This resulted in only 2.0 MB of usable
 buffer space.  Worst case, if we tried to read the whole buffer there
 would be no space left for new data)  Since hdhomerun_video_recv is a
 lightweight function, I don't see any harm in calling it more often with a
 smaller size.

Ticket URL: <http://svn.mythtv.org/trac/ticket/4213#comment:3>
MythTV <http://svn.mythtv.org/trac>

More information about the mythtv-commits mailing list