[mythtv-commits] Ticket #3794: NVP::EnableEdit stuck in loop waiting for GetPause

[MythTV]

#3794: NVP::EnableEdit stuck in loop waiting for GetPause
---------------------+------------------------------------------------------
 Reporter:  stuartm  |        Owner:  danielk
     Type:  patch    |       Status:  closed 
 Priority:  minor    |    Milestone:  0.21   
Component:  mythtv   |      Version:  head   
 Severity:  medium   |   Resolution:  fixed  
  Mlocked:  0        |  
---------------------+------------------------------------------------------
Changes (by danielk):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 (In [14821]) Fixes #3794. Fixes a race condition which can cause 'E'dit to
 get stuck waiting for a pause to take effect.

 The problem is that a Play could get executed while the after the 'E'dit
 processing function in the NVP had determined that the playback is paused.
 With this change GetPause() has been renamed IsPaused() and has an added
 param which tells you if someone has just executed a Play so that the
 pause is about to be undone, combined with locking and a check for whether
 we are starting editing in the Play() function this allows us to ensure
 that playback is really paused when we need it to be.

 Tested by myself and Stuart M & reviewed by Stuart M.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3794#comment:5>
MythTV <http://svn.mythtv.org/trac>
MythTV