#3479: patch for separating aspect ratio override and zoom modes
------------------------------------------------+---------------------------
Reporter: Petr Stehlik <pstehlik at sophics.cz> | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: mythtv | Version: unknown
Severity: medium |
------------------------------------------------+---------------------------
The zoom.diff patch separates the aspect ratio overrides (4:3 or 16:9) and
custom zoom modes intended for getting rid of the letterboxed black bars
or for better use of 16:9 screen for 4:3 materials. Daniel suggested me to
do this before implementing my 14:9 custom zoom mode some 11 months ago.
It was developed and tested on 0.20-fixes using the separate
zoom-0.20-fixes.diff (apply the 0.20-fixes.diff to your 0.20-fixes tree
first before applying the main zoom.diff patch) but the zoom.diff patch is
naturally against svn trunk.
I tried to tripple-check everything so I hope it's correct. I tested it
both on 4:3 and 16:9 screen with 4:3 and 16:9 material. The Half (14:9)
and Full zoom modes work correctly but I am not sure about the Stretch
mode. I don't see when it is to be used - I probably don't have proper
source material for testing it. I suppose that the math in
ApplyLetterboxing() could be improved or simplified now (maybe I got mixed
the original Fill and Stretch modes) but that can come in a separate patch
later.
More intelligent "Fill" zoom mode can be added when automatic black bars
detection is implemented, until that it's just guessing how much user
wants to zoom in and I think the Half zoom is an useful addition (used by
myself exclusively for watching 4:3 video on 16:9 display).
The "AdjustFill" was used instead of more natural "Zoom" because there is
another Zoom (a manual one) already and I wanted to avoid confusion in the
source code. I wouldn't be surprised if some things were renamed by native
speakers before commiting so I didn't modify any documentation or
translation files yet.
I'd change the "W" key used for cycling between the aspect modes to toggle
the new zoom mode instead but I didn't want to make it part of this patch
because users in some countries still find the aspect override switch
useful.
GUI setting in mythfrontend was separated as well but the Zoom selector
was not enabled since it doesn't fit on the screen. And besides that it's
not useful as a global option, I am afraid. Others suggested to make it
part of playback groups or something so once this patch is accepted they
can build on top of that...
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/3479>
MythTV <http://svn.mythtv.org/trac>
MythTV