[mythtv-commits] Ticket #3636: MythMainWindow::TranslateKeyPress bug?

[MythTV]

#3636: MythMainWindow::TranslateKeyPress bug?
-----------------------+----------------------------------------------------
 Reporter:  anonymous  |       Owner:  ijr    
     Type:  defect     |      Status:  new    
 Priority:  minor      |   Milestone:  unknown
Component:  mythtv     |     Version:  head   
 Severity:  medium     |     Mlocked:  0      
-----------------------+----------------------------------------------------
 When watching live tv and with the "Program Guide" jump
 point and "GUIDE" in TV Playback context are both set to 'S' I see a
 flash of the live tv in guide screen before the "Program Guide" page
 renders?

 I have placed some debug VERBOSE statements in tv_play.cpp and
 mythmainwindow.cpp and have noticed that:

  *  When watching live tv and I hit 'S' that ignoreKeys is false when
 TV::ProcessKeypress() is called.

  * This means the first TranslateKeyPress()@2188 won't be run.

  * The jump point is scheduled by TranslateKeyPress("ITV Menu",...)@2257
 and the return is false and program flow continues.

  * The call gContext->GetMainWindow()->TranslateKeyPress("TV
 Playback",...)@2266 return true so program flow continues and the GUIDE
 action is launched @3072.

  * It is slightly after the GUIDE is displayed (the video isn't painted
 yet) that the jump point kicks in and switches to the Program Guide.

  * This could happen for any jumppoint and local action that shares the
 same keybinding as far as I can tell.

 ----


 Two questions:

 Q1/ Should MythMainWindow::TranslateKeyPress first check to see if a jump
 point is currently queued (!d->exitmenucallback == NULL) and simply return
 false if it is?

 Q2/ Should there be a test for jump points at the start of
 TV::ProcessKeypress() so they are handled before all the other stuff?

 Attached is the patch to insert the debug statements I used.

 PS: I posted on the -dev list but it didn't get any response so I created
 the ticket...

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3636>
MythTV <http://svn.mythtv.org/trac>
MythTV