[mythtv-commits] Ticket #2614: MythNews crash when news URL is incorrect

MythTV mythtv at cvs.mythtv.org
Wed Jul 18 19:52:58 UTC 2007

#2614: MythNews crash when news URL is incorrect
 Reporter:  otto at kolsi dot fi  |        Owner:  stuartm
     Type:  defect                |       Status:  new    
 Priority:  minor                 |    Milestone:  0.21   
Component:  mythnews              |      Version:  head   
 Severity:  medium                |   Resolution:         
  Mlocked:  0                     |  

Comment(by stuartm):

 The attached backtrace doesn't really help at all. It sounds like a race
 condition and I might stumble across a fix by trying a few things and
 crossing my fingers but I don't have mythnews installed or the time to do

 You could try moving stop() from the end of NewsSite::slotFinished to the
 top. Or a more likely fix would be to block repeated calls to
 site->retrieve() while m_RetrieveTimer->isActive() or using another block

 MythNews::slotRetrieveNews is a little strange, it loops through the list
 of sites three times and calls site->stop() on each site twice (see
 cancelRetrieve()). One loop connects the NewsSite::finished signal, but
 retrieve isn't called until we reach the second loop. We also connect that
 signal every time the function is called and never disconnect it which I
 think has the potential to get very, very messy (single signal resulting
 in a slot be called several times over).

Ticket URL: <http://svn.mythtv.org/trac/ticket/2614#comment:2>
MythTV <http://svn.mythtv.org/trac>

More information about the mythtv-commits mailing list