[mythtv-commits] mythtv commit: r12675 by danielk

mythtv at cvs.mythtv.org mythtv at cvs.mythtv.org
Tue Jan 30 14:38:02 UTC 2007

      Author: danielk
        Date: 2007-01-30 14:38:02 +0000 (Tue, 30 Jan 2007)
New Revision: 12675
   Changeset: http://cvs.mythtv.org/trac/changeset/12675




Fixes #3004. Fixes race with "Watch as it records".

If scheduler wants to use the recorder you are watching LiveTV on and you decide to watch as it records, there can be a race with normal end of program ringbuffer switching. If the program you are watching ends while the scheduler is running the code in StartRecording and is on line 463 (the event flush), then the ring buffer switch for the next program will be started, but if the recorder is a digital recorder and has not found a keyframe before StartRecording gets to line 533 then the ringbuffer change for the scheduled recording will partially overwrite the in flight ringbuffer switch.

This change avoids this race by moving the delete of the pendingRecording until after the new scheduled recording is setup so that the normal end of program ringbuffer switching is not triggered while StartRecording is running.

More information about the mythtv-commits mailing list