[mythtv-commits] Ticket #2978: Expand "Action on playback exit" option to include Live TV

MythTV mythtv at cvs.mythtv.org
Sat Jan 27 10:20:21 UTC 2007

#2978: Expand "Action on playback exit" option to include Live TV
 Reporter:  Neil McBride <neil at castinian.org>  |        Owner:  skamithi
     Type:  enhancement                        |       Status:  new     
 Priority:  minor                              |    Milestone:  unknown 
Component:  mythtv                             |      Version:  head    
 Severity:  low                                |   Resolution:          
Changes (by Neil McBride <neil at castinian.org>):

 * cc: neil at castinian.org (removed)


 I've cleaned this up some and made the menu orders when exiting standard
 across the type of program being watched.  The patch adds two new
 functions to the TV class as outlined below.  These aren't essential, but
 the code ends up being much cleaner, and these functions should be
 suitable for other uses as well.

 * Swapped around the menu order so the first option is to just exit to the
 menu for all types.  This seems to make the most sense considering 'keep
 watching' can be achieved by pressing stop again, and setting a bookmark
 or  deleting would require actual navigation of the menu, while simply
 exiting  which I would assume would be the most frequent option used is a
 simple  matter of pressing stop then select.

 * Added two functions BookmarkAllowed and DeleteAllowed to return
 true/false  whether or not the action is appropriate for what is being
 watched.  This  and the reordering allowed me to consolidate some of the
 code and make it  a littler cleaner.  I'm told there is a unified bookmark
 system being written  so I expect at least one of these will not be
 necessary once that is complete.

 * Removed the code that sets bookmarks and watched flags for Live TV - I
 can't  think of a reason for it at least.

 I've tested with Live TV, recordings, videos and DVD, including the
 optional bookmarking.  It all seems to work well.  Let me know if there's
 any problems.

Ticket URL: <http://svn.mythtv.org/trac/ticket/2978#comment:3>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list