[mythtv-commits] mythtv commit: r12485 - in trunk/mythtv by danielk

[mythtv at cvs.mythtv.org]

      Author: danielk
        Date: 2007-01-12 01:46:26 +0000 (Fri, 12 Jan 2007)
New Revision: 12485
   Changeset: http://cvs.mythtv.org/trac/changeset/12485

Modified:

   trunk/mythtv/libs/libmyth/mythcontext.cpp
   trunk/mythtv/libs/libmyth/mythcontext.h
   trunk/mythtv/libs/libmyth/util-x11.cpp
   trunk/mythtv/programs/mythfrontend/main.cpp
   trunk/mythtv/programs/mythtv-setup/main.cpp
   trunk/mythtv/programs/mythtv/main.cpp

Log:

Fixes #2865. Fixes SEGFAULT when -display used without another valid display in DISPLAY env variable.

Unfortunately this requires a MYTH_BINARY_VERSION change so you must recompile & install the plugins after installing the update mythtv libraries.

The problem was that we attempted to open the display before we had parsed and/or set the MythContext's X11 display string. This meant that at best we opened the wrong display when detecting the screen settings the first time, and at worst we segfaulted if the DISPLAY environment variable wasn't set to a valid X11 server.