[mythtv-commits] Ticket #2957: Port to FLAC 1.1.3
MythTV
mythtv at cvs.mythtv.org
Sun Feb 18 06:26:38 UTC 2007
#2957: Port to FLAC 1.1.3
-----------------------+----------------------------------------------------
Reporter: ankoe | Owner: jarod
Type: task | Status: closed
Priority: minor | Milestone: unknown
Component: mythmusic | Version: head
Severity: low | Resolution: fixed
-----------------------+----------------------------------------------------
Comment (by nigel):
Jarod, tried to get in before you committed, but failed :-( Was wondering
if you could further simplify the #defines up the top by removing the
duplication - using something like:
{{{
#if !defined(FLAC_API_VERSION_CURRENT) || FLAC_API_VERSION_CURRENT <= 7
/* FLAC 1.0.4 to 1.1.2 */
#include <FLAC/file_encoder.h>
#define FLACENC FLAC__file_encoder
#else
/* FLAC 1.1.3 and up */
#define NEWFLAC
#include <FLAC/stream_encoder.h>
#define FLACENC FLAC__stream_encoder
#endif
#define encoder_new() FLACENC_new()
#define encoder_setup(enc, streamable_subset, do_mid_side_stereo, \
loose_mid_side_stereo, channels, bits_per_sample, \
sample_rate, blocksize, max_lpc_order, \
qlp_coeff_precision, do_qlp_coeff_prec_search, \
do_escape_coding, do_exhaustive_model_search, \
min_residual_partition_order, max_residual_partition_order, \
rice_parameter_search_dist) \
{ \
FLACENC_set_streamable_subset(enc, streamable_subset); \
...
}}}
''et c.'' (same with FLAC__Seekable ''vs'' FLAC__).
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/2957#comment:7>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list