[mythtv-commits] Ticket #3061: MSqlQuery.size() removal for libmythtv
MythTV
mythtv at cvs.mythtv.org
Fri Feb 9 21:16:39 UTC 2007
#3061: MSqlQuery.size() removal for libmythtv
-----------------------+----------------------------------------------------
Reporter: anonymous | Owner: ijr
Type: patch | Status: new
Priority: minor | Milestone: unknown
Component: mythtv | Version: head
Severity: medium | Resolution:
-----------------------+----------------------------------------------------
Comment (by david at hardeman.nu):
I've reviewed the latest patch, and first of all...beautiful. It removes
around 700 unnecessary function calls. The diffstat says a lot about how
much work it is:
{{{
cardutil.cpp | 37 ++++-----
channel.cpp | 2
channelbase.cpp | 26 +++---
channeleditor.cpp | 17 +---
channelsettings.cpp | 16 ++-
channelsettings.h | 15 +--
channelutil.cpp | 100 +++++++++++++++---------
customedit.cpp | 8 -
datadirect.cpp | 15 +--
dbcheck.cpp | 14 +--
dbox2channel.cpp | 6 -
dbox2epg.cpp | 4
diseqc.cpp | 20 ++--
dtvchannel.cpp | 6 -
dtvmultiplex.cpp | 2
dvbchannel.cpp | 5 -
eit.cpp | 2
eitcache.cpp | 4
eithelper.cpp | 4
eitscanner.cpp | 2
iptvchannel.cpp | 2
jobqueue.cpp | 104 ++++++++-----------------
livetvchain.cpp | 6 -
mhi.cpp | 4
mpegrecorder.cpp | 2
profilegroup.cpp | 16 +--
progfind.cpp | 24 +++--
proglist.cpp | 12 --
programdata.cpp | 34 +++-----
programinfo.cpp | 201
+++++++++++++++++++------------------------------
recordingprofile.cpp | 26 +++---
remoteencoder.cpp | 2
scanwizardhelpers.cpp | 4
scheduledrecording.cpp | 9 --
siscan.cpp | 16 +--
sourceutil.cpp | 16 +--
sr_items.cpp | 2
sr_items.h | 6 -
storagegroup.cpp | 12 +-
transporteditor.cpp | 8 -
tv_play.cpp | 14 +--
tv_rec.cpp | 42 ++++------
videodev_myth.h | 12 +-
videoout_xv.cpp | 3
videosource.cpp | 31 +++----
yuv2rgb.cpp | 11 ++
46 files changed, 436 insertions(+), 488 deletions(-)
}}}
It looks almost perfect, some things to fix though:
* You introduce a spelling error in dbcheck.cpp (see the last line):
{{{
- if (!recordids.exec())
- return false;
- if (recordids.isActive() && recordids.size() > 0)
+ if (recordids.ecec())
}}}
* The changes to videodev_myth.h are completely unrelated to the SQL
changes
* Same thing goes for videoout_xv.cpp
* Same thing goes for mpegrecorder.cpp
* Same thing goes for yuv2rgb.cpp
* You haven't resolved the conflict in channelutil.cpp (search that file
for "<<<<" and you'll see it)
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/3061#comment:11>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list