[mythtv-commits] Ticket #3815: Bugs in MediaMonitorUnix

[MythTV]

#3815: Bugs in MediaMonitorUnix
-----------------------+----------------------------------------------------
 Reporter:  anonymous  |       Owner:  ijr    
     Type:  defect     |      Status:  new    
 Priority:  minor      |   Milestone:  unknown
Component:  mythtv     |     Version:  head   
 Severity:  medium     |     Mlocked:  0      
-----------------------+----------------------------------------------------
 There are two problems with MediaMonitorUnix:

 1. When it scans /sys/block/<devicename> for partitions it treats file
 names as directories and tries to cd (change directory) into them.  This
 of course fails and then the corresponding cdUp() leaves the QDir object a
 directory above where it is supposed to be.  This then causes undefined
 behaviour (in my case I was getting MediaEvents telling me that $HOME had
 just been mounted).  The attached patch fixes this.

 2. The committed changes for ticket #3662 are not quite correct.  Although
 they will stop /dev/sda itself from being monitored, partitions in
 /dev/sda will still be checked by FindPartitions() and then the call to
 AddDevice() will succeed.  MythHDD::checkMedia() will then attempt to
 mount the partitions (which in my case fails, but it shouldn't be called
 at all if the device is to be ignored).  shouldIgnore() should be called
 at the top of MediaMonitorUnix::FindPartitions() as per the original
 patch.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/3815>
MythTV <http://svn.mythtv.org/trac>
MythTV