[mythtv-commits] Ticket #2426: enhancement: embed playback box, move end of recording prompts to the OSD.

MythTV mythtv at cvs.mythtv.org
Tue Sep 19 18:58:56 UTC 2006

#2426: enhancement: embed playback box, move end of recording prompts to the OSD.
 Reporter:  skamithi     |       Owner:  skamithi
     Type:  enhancement  |      Status:  new     
 Priority:  minor        |   Milestone:  0.21    
Component:  mythtv       |     Version:  head    
 Severity:  medium       |  
 I posted a huge diff couple weeks back on the dev alias and got some good
 feedback on it.

 This is the first part I wish to submit. I hope it to be a replacement for
 the "Jump to Recorded Programs" OSD option.

 Embedding the playback box involves 4 steps

 1) Consolidate the tv object creation code. Created a startTV function
 that other parts of mythtv can call to start watching a live tv stream or
 a recording. I've made sure that playlists still works.

 2) Add the code in playbackbox.h/cpp , and tv_play.cpp to allow embedding
 of the playbackbox widget, and cleanup/remove unused functions/variables.

 3) Move the playbackbox.h and playbackbox.cpp to libmythtv directory.

 4) Ask theme developers to create a new window called "playback-video".
 This container is essentially playback container  with an object called
 "tv_video", where the recording will be shown. If a theme doesn't have a
 playback-video container, recording is paused, the "playback" container is

 1st step is done. I've made 3 changes to mythtv functionality:

   i) End of the recording prompt has been moved to the OSD space. Doing
 this also allows you to rewind, in case you've forwarded too far, and
 reached the end of the recording.

  ii) (and i can change this back to the current mapping). Added a
 "STOPSHOW" action.
  On my remote, i have an "exit" and a "stop" button. When i hit stop, I
 want it to prompt me. When I hit "exit" i want it to quit the show, with
 no prompt. the "stopshow" action maps to the "stop" button. This way, when
 I hit the "off" key on my harmony remote, it exits, the show. Before, it
 would just show the prompt, and never quit.

  If this change is accepted, then in the dialog  displayed, a dev can add
 "delete recording" option at a later stage. Selecting "Delete recording"
 should bring up another dialog asking if you are sure , just like the end
 of recording prompt. This will allow a user to delete a show midstream if
 necessary. Right now the OSD dialog only accepts 4 buttons. Looks like a
 theme change needs to be made to accomodate 5 buttons in the dialog.

  iii) When prompted to exit the video, the prompt will remain up for only
 2 minutes, then stop displaying,  and either exit the show, if at the end,
 or continuing to play the show.

 I haven't changed the tv object creation code in manualbox.cpp. I don't
 really know what the manualbox is for, so decided not to touch it.

 Thoughts, comments are always welcome. my IRC name is skamithi.

Ticket URL: <http://svn.mythtv.org/trac/ticket/2426>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list