[mythtv-commits] Ticket #2504: Allow myth to compile against upstream ivtv.h
MythTV
mythtv at cvs.mythtv.org
Fri Oct 27 00:30:52 UTC 2006
#2504: Allow myth to compile against upstream ivtv.h
-----------------------------------+----------------------------------------
Reporter: mrsam at courier-mta.com | Owner: danielk
Type: defect | Status: reopened
Priority: trivial | Milestone: 0.21
Component: mythtv | Version: head
Severity: low | Resolution:
-----------------------------------+----------------------------------------
Comment (by miwer):
thanks daniel, using that option makes VBI recording work again for me -
it isn't defined in my SVN ebuild. Shouldn't it be the default behavior
for mythtv to use the upstream ivtv headers in the future? Default atm is
ivtv_header=no
I tried inserting some code to reveal which ioctls are defined or not, and
tested this with mythtv headers and ivtv upstream headers. Here's the
result:
myth_ivtv headers
{{{
2006-10-27 01:35:41.477 IVTV_IOC_S_VBI_MODE defined
2006-10-27 01:35:41.478 V4L2_BUF_TYPE_SLICED_VBI_CAPTURE _not_ defined
2006-10-27 01:35:41.479 Can't enable VBI recording
eno: Invalid argument (22)
2006-10-27 01:35:41.480 IVTV_IOC_S_VBI_EMBED defined
2006-10-27 01:35:41.481 IVTV_IOC_G_VBI_MODE defined
}}}
ivtv headers
{{{
2006-10-27 01:11:07.991 IVTV_IOC_S_VBI_MODE _not_ defined
2006-10-27 01:11:07.992 V4L2_BUF_TYPE_SLICED_VBI_CAPTURE _not_ defined
2006-10-27 01:11:07.993 Can't enable VBI recording
eno: Success (0)
2006-10-27 01:11:07.995 IVTV_IOC_S_VBI_EMBED defined
2006-10-27 01:11:07.996 IVTV_IOC_G_VBI_MODE _not_ defined
}}}
There's one little quirk here, the ifdefs you've defined result in the
following code compiled, which of course will always generate the above
"error" message, which - despite the look of it - does ''not'' indicate
the success of enabling VBI recording. /me thinks that happens in the 3rd
ifdef. Correct me if I'm wrong.
{{{
if (vbimode)
{
{
{
VERBOSE(VB_IMPORTANT, "Can't enable VBI recording" + ENO);
}
}
...
}}}
... maybe some moving it around a bit will fix this. It's a minor glitch,
I know, but still... :)
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/2504#comment:5>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list