[mythtv-commits] Ticket #2434: Workaround for hangs when ffwd/rewinding video

[MythTV]

#2434: Workaround for hangs when ffwd/rewinding video
---------------------------------------------+------------------------------
 Reporter:  matt-bulk-mythtv at holgate.org.uk  |        Owner:  ijr    
     Type:  patch                            |       Status:  new    
 Priority:  minor                            |    Milestone:  unknown
Component:  mythtv                           |      Version:  head   
 Severity:  medium                           |   Resolution:         
---------------------------------------------+------------------------------
Comment (by Matt Holgate <matt-bulk-mythtv at holgate.org.uk>):

 Ok, I've had a go at trying to fix this properly.

 The new patch I'm about to upload is a much better solution which prevents
 the race condition by ensuring the PauseVideo() is only ever called from a
 single thread (the decoder thread). This ensures that pause/unpause
 operations are thread safe.

 The only issues that I'm concerned about are:

   - it's no longer possible to call NVP::Pause with waitvideo==false (but
 I can't find any code that does this anyway. I've not changed the API to
 remove the parameter because I guess this would be a bad idea on the fixes
 branch
   - calling NVP::PauseDecoder now always causes the video/audio to be
 paused as well (I've no idea if this is an issue or not).

 I've only tested this patch very briefly, but it seems to fix the issue.
 I'll run with it for the next few days and see how it fares. If anyone
 else would like to test it too, that would be great.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/2434#comment:11>
MythTV <http://www.mythtv.org/>
MythTV