[mythtv-commits] Ticket #2434: Workaround for hangs when ffwd/rewinding video

[MythTV]

#2434: Workaround for hangs when ffwd/rewinding video
---------------------------------------------+------------------------------
 Reporter:  matt-bulk-mythtv at holgate.org.uk  |        Owner:  ijr    
     Type:  patch                            |       Status:  new    
 Priority:  minor                            |    Milestone:  unknown
Component:  mythtv                           |      Version:  0.20   
 Severity:  medium                           |   Resolution:         
---------------------------------------------+------------------------------
Comment (by matt-bulk-mythtv at holgate.org.uk):

 The only (serious) instance that I can immediately think of might be that
 pressing pause while seeking could cause the same thing. I don't know if
 this is a problem in practice though (this would happen because we wait
 for the video to be unpaused in a loop).

 Also, maybe we should check that the video really is paused (by calling
 GetVideoPause()) after other calls to PauseVideo() in the same file (since
 PauseVideo can now return with the video not actually paused with my
 patch).

 Another option would be to add a lock to make sure that the setting of
 pausevideo and the wait for video_actually_paused to become true is
 atomic. In fact, a lock around the whole "Pause, DoFastForward, Unpause",
 and the NuppelVideoPlayer::Pause() and NuppelVideoPlayer::Play() code
 might be a more robust way of fixing this, to ensure that user
 interactions don't interfere with programmaticly introduced pauses?

 Isaac - any thoughts on this?

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/2434#comment:3>
MythTV <http://www.mythtv.org/>
MythTV