[mythtv-commits] Ticket #1748: External text-based subtitle file support for the internal video player

[MythTV]

#1748: External text-based subtitle file support for the internal video player
---------------------------------------------------------------+------------
 Reporter:  Pekka Jääskeläinen <pekka.jaaskelainen at gmail.com>  |        Owner:  danielk
     Type:  patch                                              |       Status:  closed 
 Priority:  minor                                              |    Milestone:  0.20   
Component:  mythtv                                             |      Version:  head   
 Severity:  medium                                             |   Resolution:  invalid
---------------------------------------------------------------+------------
Changes (by danielk):

  * resolution:  => invalid
  * status:  new => closed

Comment:

 Pekka, a few problems:

  * TABs are bad.
  * Please use the same bracketing as the rest of MythTV.
  * QStrings are not thread safe, use a mutex and qdeepcopy when allowing
 more than one thread to access a string.
  * make all get methods const methods.
  * using a linear search for the current subtitle will not deal with
 seeking all that well. Using the STL binary search find would be pretty
 easy.
  * passing iterators around is kind of scary, these can be invalidated by
 a change to the underlying structure. If you reload the subtitles you can
 easilly get a segfault.
  * osd.cpp has the patch in #1515 applied; please remove this.


 Please reopen the ticket when the patch is ready.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1748>
MythTV <http://www.mythtv.org/>
MythTV