[mythtv-commits] Ticket #1788: H264 tools patch

[MythTV]

#1788: H264 tools patch
-----------------------------------------+----------------------------------
 Reporter:  jean-michel.bouffard at crc.ca  |        Owner:  danielk 
     Type:  enhancement                  |       Status:  assigned
 Priority:  minor                        |    Milestone:  0.20    
Component:  mythtv                       |      Version:  head    
 Severity:  medium                       |   Resolution:          
-----------------------------------------+----------------------------------
Changes (by danielk):

  * milestone:  unknown => 0.20
  * status:  new => assigned

Comment:

 Very cool.

 NALUnitType should be formatted so that the major bits are indented
 4 chars instead of 8, and we line things like:
 {{{
       if (type > UNKNOWN && type < SEI) return true;
       return false;
 }}}
 to be formatted as so:
 {{{
       if (type > UNKNOWN && type < SEI)
           return true;
       return false;
 }}}
 or better yet:
 {{{
       return (type > UNKNOWN) && (type < SEI);
 }}}

 But those I could fix. What I'm concerned about is the "throws()"
 I didn't see you throwing anything, but does this means you are
 not checking for common error values from the C/C++ libs?

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1788>
MythTV <http://www.mythtv.org/>
MythTV