[mythtv-commits] Ticket #1586: LCD::Get() creates LCD object, even when disabled

[MythTV]

#1586: LCD::Get() creates LCD object, even when disabled
----------------------------------+-----------------------------------------
 Reporter:  perveilerj at yahoo.com  |       Owner:  ijr
     Type:  patch                 |      Status:  new
 Priority:  minor                 |   Milestone:     
Component:  mythtv                |     Version:     
 Severity:  medium                |  
----------------------------------+-----------------------------------------
 While debugging something entirely unrelated I noticed that calls to
 LCD::Get() were returning non-NULL even though I have the LCD stuff
 disabled in my settings.  As a result anybody using LCD::Get() to
 determing whether they should do LCD-update stuff was doing the work
 anyways despite the fact that the results would go unused in the LCD
 object itself (in my case it was TV::RunTV() making the extra effort).

 This patch tracks the global setting better and prevents LCD::Get() from
 newing LCDs if the LCD is disabled in the settings, regardless of
 m_server_unavailable.

 This works for my purposes, but I don't have a LCD to regression test with
 so somebody with the hardware should probably test this before it gets
 committed.

 --Jack

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1586>
MythTV <http://www.mythtv.org/>
MythTV