[mythtv-commits] Ticket #1392: invalid read in PESPacket::PESPacket()

MythTV mythtv at cvs.mythtv.org
Sun Mar 12 00:21:57 UTC 2006

#1392: invalid read in PESPacket::PESPacket()
 Reporter:  janne-mythtv at grunau.be  |        Owner:  danielk
     Type:  defect                  |       Status:  closed 
 Priority:  minor                   |    Milestone:  0.20   
Component:  dvb                     |      Version:  head   
 Severity:  low                     |   Resolution:  fixed  
Changes (by danielk):

  * milestone:  => 0.20
  * version:  => head


 That 0x00 is for the start of field pointer, but since I moved the offset
 of the PES packets to match the DVB drivers a few weeks ago it should now
 be considered part of the TS packet rather than the PES packet so I moved
 it. This also makes more sense in the case of multiple PSIP sections per
 TS packet, which is allowed by the DVB standard (but not by the ATSC for
 which this parser was originally written.)

 The actual fix in the patch was in the length setting in those CreateBlank
 functions. We set the length so that exactly 188 bytes of the 188 byte TS
 Packet are copied just before the packet copy, and then set it to the
 proper length right afterward. This means we copy just the right number of
 bytes, but the length is still set properly by the end of the function.

Ticket URL: <http://svn.mythtv.org/trac/ticket/1392>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list