[mythtv-commits] Ticket #1945: DVB-S/diseqc patch

[MythTV]

#1945: DVB-S/diseqc patch
--------------------------------+-------------------------------------------
 Reporter:  yeasah at schwide.net  |        Owner:  danielk
     Type:  enhancement         |       Status:  new    
 Priority:  minor               |    Milestone:  0.20   
Component:  mythtv              |      Version:  head   
 Severity:  medium              |   Resolution:         
--------------------------------+-------------------------------------------
Comment (by yeasah at schwide.net):

 Replying to [comment:11 danielk]:
 > (In [10322]) Refs #1945. Initial commit of new DiSEqC code to diseqc
 branch.
 >
 > Yeasah, can you have a look over this and make sure it still works? I
 removed some code that looked like unrelated fixes. If they are related
 please generate a patch against this (w/explanation), if not generate a
 patch and ticket for each one against SVN head.

 I'll give it a test when I can, but I did notice a few things just going
 over the changeset, I think at the very least the last two will have to be
 corrected in one way or another before the stuff will work properly:

 * The always-use-auto-FEC thing is still in there, I never did take that
 out (sorry about that) -- line 749 of dvbchannel.cpp

 * The couple changes that you left out from siscan.cpp are indeed not
 related to the diseqc patch (DVB-S scanning fixes that leaked into the
 patch), so that's fine.

 * The changes to libmyth/settings.cpp+h are needed for the device tree
 editor to work properly. The change allows the myth listbox to have
 multiple strings with the same displayed value, which is needed for the
 GUI since the tree display is actually just an indented listbox -- and
 tree nodes can easily have the same name.

 * The code added to dvbchannel.cpp to delete the diseqc_tree object will
 cause crashes with the current implementation -- the lifetimes of tree
 objects is currently managed by the diseqcdevtrees class, so deleting the
 object in dvbchannel will leave an outstanding reference to a deleted
 object, which will either be reused or re-deleted at some future point.

 On an unrelated note, if it's easy to take the new rotor position status
 signal monitor value and stick it in the OSD, that would be a really nice
 addition to this patch. I have a pretty rough understanding of the signal
 monitor code, so I didn't want to do much more to that stuff than was
 necessary in the patch.

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/1945>
MythTV <http://www.mythtv.org/>
MythTV