[mythtv-commits] Ticket #1704: Patch to use freebox set top box ADSL modem as a TV source

[MythTV]

#1704: Patch to use freebox set top box ADSL modem as a TV source
------------------------------+---------------------------------------------
 Reporter:  mythtv at ambre.net  |        Owner:  danielk
     Type:  patch             |       Status:  closed 
 Priority:  minor             |    Milestone:  unknown
Component:  mythtv            |      Version:  head   
 Severity:  low               |   Resolution:  invalid
------------------------------+---------------------------------------------
Changes (by danielk):

  * resolution:  => invalid
  * status:  new => closed

Comment:

 I took a look at the patch.

 In particular I rewrote the FreeBoxChannel code. It inherited from QObject
 which it shouldn't have. It didn't obey the 80 column limit. It didn't
 implement one of the SwitchToInput() methods, IsOpen() returned true even
 if it Open failed, and SetChannelByString() didn't return false if it
 failed to find the channel in the list of valid channels.

 There are a few things that need to be done.

 I didn't fix many similar problems in FreeBoxRecorder and
 FreeboxMediaSink(). There is no mythtv-setup code to add a
 FreeBoxRecorder. There is no signal monitor to determine if the media
 server is running and returning data. There is no 'channel scan' to add
 the channels fetched by FreeBoxChannel to the DB. The livemedia library
 should be added to MythTV as libmythlivemedia, especially since the
 Live555 folks do not yet have any "make install" to install the headers
 and libraries in proper locations.
 Methods not implemented in base classes should have doxygen documentation.
 FreeboxRecorder does nothing to filter the PAT/PMT, and runs video
 keyframe finding code on all the streams, not just the main video stream;
 see HDHRRecorder, FirewireRecorderBase, HDTVRecorder or DVBRecorder for
 different approaches to this.

 Reopen the ticket when the patch is ready.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1704>
MythTV <http://www.mythtv.org/>
MythTV