[mythtv-commits] Ticket #1945: DVB-S/diseqc patch

[MythTV]

#1945: DVB-S/diseqc patch
--------------------------------+-------------------------------------------
 Reporter:  yeasah at schwide.net  |        Owner:  danielk
     Type:  enhancement         |       Status:  new    
 Priority:  minor               |    Milestone:  0.20   
Component:  dvb                 |      Version:  head   
 Severity:  medium              |   Resolution:         
--------------------------------+-------------------------------------------
Comment (by anonymous):

 Replying to [comment:37 danielk]:
 > Yeasah, can you do this without the "cur_tuning = tuning" in Tune()?
 > It is a bit confusing since a lot of the tuning functions actually call
 Tune() with cur_tuning as the first paramater. It is really intended as a
 temporary variable used in calculating the tuning parameters so it often
 in an inconsistent state.

 If cur_tuning isn't appropriate as the desired tuning state either, the
 most obvious solution would be to add yet another DVBTuning member
 variable (called desired_tuning?) which is assigned in the same place as
 the "cur_tuning = tuning" assignment you're talking about, and have
 Retune() use that instead of cur_tuning.

 I think it would be good to eliminate cur_tuning if possible if it's just
 used to ferry temporary state around -- it looks like it's just used to
 propagate tuning info back from ParseTuningParams via GetTransportOptions,
 but I think those could just as easily modify a supplied tuning value
 argument and avoid the need to store them in class state. Maybe I missed
 somewhere that the cur_tuning state is needed across public method calls,
 but I didn't see anything like that.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1945>
MythTV <http://www.mythtv.org/>
MythTV