[mythtv-commits] Ticket #2154: Patch to make mythgallery scale according to screen aspect ratio

MythTV mythtv at cvs.mythtv.org
Wed Dec 13 17:56:09 UTC 2006


#2154: Patch to make mythgallery scale according to screen aspect ratio
------------------------------+---------------------------------------------
 Reporter:  drdaz7 at gmail.com  |        Owner:  danielk
     Type:  enhancement       |       Status:  closed 
 Priority:  minor             |    Milestone:  0.21   
Component:  mythgallery       |      Version:  head   
 Severity:  low               |   Resolution:  invalid
------------------------------+---------------------------------------------
Changes (by danielk):

  * status:  reopened => closed
  * resolution:  => invalid

Comment:

 The XOpenDisplay calls don't specify the display to open, have a look how
 videoout_xv.cpp sets the display_aspect variable wrt to Xinerama and use
 MythXOpenDisplay so that you open the correct display.

 Also there are several potential divide by zero possibilities in
 getScaleFactorW() and getScaleFactorH(). Please avoid these coredumps and
 replace with these single function GetDisplayAspect() to match the video
 output code.

 Formatting, 4 spaces for intentation, "if" is not a function, don't use
 K&R bracing, 80 chars per line max, etc. See the formatting guidelines
 linked to from the TicketHowTo.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/2154#comment:6>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list