[mythtv-commits] Ticket #1699: Patch for MythMusic and Mythweb
MythTV
mythtv at cvs.mythtv.org
Mon Apr 17 15:38:51 UTC 2006
#1699: Patch for MythMusic and Mythweb
-------------------------+--------------------------------------------------
Reporter: joggl | Owner: ijr
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: mythtv | Version:
Severity: medium | Resolution:
-------------------------+--------------------------------------------------
Comment (by Colin Guthrie <mythtv at colin.guthr.ie>):
Lin 82 of mythmusic/mythmusic/main.cpp should read: data->setBitrate, not
data.setBitrate.... tho' why this is hard coded I don't know? Surely the
decoders' getMetadata() call should be responsible for setting this? Ditto
for the file size as they may have this already. Also you derefernce the
point data without doing the Null check that is done below your checks...
Not looked properly yet, but this is certainly a bug.
If you would like me to do a cleanup on the patch, let me know. I'll
review and alter it accodingly but we need to make sure we don't get
conflicts with each other!!
--
Ticket URL: <http://svn.mythtv.org/trac/ticket/1699>
MythTV <http://www.mythtv.org/>
MythTV
More information about the mythtv-commits
mailing list