[mythtv-commits] Ticket #1653: Add IRC freqtable to per-video-source setting

MythTV mythtv at cvs.mythtv.org
Sun Apr 9 22:47:56 UTC 2006


#1653: Add IRC freqtable to per-video-source setting
----------------------------------------------+-----------------------------
 Reporter:  sphery <mtdean at thirdcontact.com>  |        Owner:  ijr
     Type:  patch                             |       Status:  new
 Priority:  trivial                           |    Milestone:     
Component:  mythtv                            |      Version:     
 Severity:  low                               |   Resolution:     
----------------------------------------------+-----------------------------
Comment (by sphery <mtdean at thirdcontact.com>):

 Although I had convinced myself that doing so was a waste of time because
 of the near-zero chance of adding a new analog frequency table in the
 future, I considered changing the approach used to populate the "Channel
 frequency table" comboboxes.  Currently, we're specifying the list of
 frequency tables in 3 places (in the chanlists[] in frequencies.c and in
 comboboxes in videosource.cpp and backendsettings.cpp).  I don't know if
 there's any particular reason for keeping all three lists, but it seems
 that using the names from chanlists[] to populate the comboboxes would
 prevent a similar discontinuity in the future.

 Therefore--because I felt guilty about the "maintenance headache" I left
 in place--I made mythtv-frequency_table_comboboxes.patch, which changes
 the comboboxes in videosource.cpp and backendsettings.cpp to pull their
 options from chanlists[] (although the one in videosource.cpp still
 retains the "default" setting at the top of the list).  Each patch stands
 on its own, and mythtv-frequency_table_comboboxes.patch obviates the need
 for mythtv-irc_video_source_freqtable_override.patch, so you can choose
 the approach you prefer.

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/1653>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list