[mythtv-commits] Ticket #392: Remove repeated pixmap updates when idle in Watch Recordings

[MythTV]

#392: Remove repeated pixmap updates when idle in Watch Recordings
----------------------------+-----------------------------------------------
 Reporter:  kuphal at dls.net  |       Owner:  ijr 
     Type:  patch           |      Status:  new 
 Priority:  minor           |   Milestone:      
Component:  mythtv          |     Version:  head
 Severity:  low             |  ----------------------------+-----------------------------------------------
 Currently, mythfrontend updates the pixmap when you have a recording
 selected in the Watch Recordings screen every 500ms by querying the
 backend if the pixmap has changed.  This is done in the code that is meant
 to update the preview window when using video preview.  It has the side
 effect of sending a great deal of chatter back and forth between the
 frontend and backend when sitting idle.

 This patch updates the videoRect in the 500ms timer only when we are
 expecting there to be a preview video.  The other screen updates when
 selecting and deselecting recordings handles the pixmap updating just fine
 without it.

 {{{
 Index: programs/mythfrontend/playbackbox.cpp
 ===================================================================
 --- programs/mythfrontend/playbackbox.cpp       (revision 7235)
 +++ programs/mythfrontend/playbackbox.cpp       (working copy)
 @@ -3254,7 +3254,8 @@
      if (titleList.count() <= 1)
          return;

 -    update(videoRect);
 +    if (playbackPreview)
 +        update(videoRect);
  }

  void PlaybackBox::keyPressEvent(QKeyEvent *e)

 }}}

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/392>
MythTV <http://www.mythtv.org/>
MythTV