[mythtv-commits] Re: Ticket #357: Patch for MythGame to support diff. Hosts

MythTV mythtv at cvs.mythtv.org
Fri Sep 23 12:55:20 UTC 2005


#357: Patch for MythGame to support diff. Hosts
----------------------+-----------------------------------------------------
 Reporter:  jochen    |        Owner:  greg
     Type:  defect    |       Status:  new 
 Priority:  minor     |    Milestone:      
Component:  mythgame  |      Version:      
 Severity:  medium    |   Resolution:      
----------------------+-----------------------------------------------------
Changes (by greg):

  * owner:  ijr => greg

Comment:

 I believe Isaac was referring to how your patch to dbcheck.cpp
 sets that columns default value to '*' instead of NULL.


  However I'm rejecting this patch as it is right now not just for that,
 but because it does not properly address the rest of the application to
 make this work.


  If you want per host emulators then you should only display the games in
 the gametree that apply to that host(or provide an indicator of what is
 not available to them). Which means you have to update the gametree code
 to support this new per host feature, and means changing how the gamescan
 information is entered in the database as it does not take into account
 that a emulator might not be available on all frontends.

  I wont be applying any patch that doesn't address the rest of this. At
 this point it's little more than a new setting on a page.

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/357>
MythTV <http://www.mythtv.org/>
MythTV


More information about the mythtv-commits mailing list