[mythtv-commits] Ticket #295: Patch to update uitype.cpp and uilistbtntype.cpp

MythTV mythtv at cvs.mythtv.org
Sun Sep 4 15:04:54 UTC 2005

#295: Patch to update uitype.cpp and uilistbtntype.cpp
 Reporter:  Paul    |       Owner:  ijr 
     Type:  patch   |      Status:  new 
 Priority:  minor   |   Milestone:      
Component:  mythtv  |     Version:  head
 Severity:  medium  |         Cc:          |  
 This patch just fixes a few inconsistencies I found in uitype.cpp and
 uilistbtntype.cpp whilst writing the new plugin for the MythBurn scripts.

 - The UIListBtnType ignores the draw context and is always drawn

 - The UIListBtnType ignores the draworder and is always redrawn regardless
 causing it to be redrawn needlessly for each layer a window definition

 - Several UITypes ignore the hidden flag and are always redrawn.

 - UIListBtnType doesn't have a recalculateScreenArea() which causes a few
 problems when trying to do a refresh() on a MythThemedDialog().

 - UICheckBoxType has a setState(bool) but no getState() to read back the
 current check state.

 - UISelectorType has no way to read back what item is currently selected.

 - UIImageType when trying to load an image from a specific location can
 load the
 wrong image if an image with the same name exists in the theme or default

 - MythThemedDialog when updating its list of focus taking widgets doesn't
 take into
 account that some widgets may be hidden or not in the current context.

 - UIListBtnType doesn't handle taking focus and loosing focus very well.

 - others that I have forgot about.

 I'd be very grateful if one of the devs could look over the patch and
 commit it so
 that anyone who wants to try the MythBurn plugin don't have to start
 myth they just need to get the latest svn version.

 thanks, Paul

Ticket URL: <http://cvs.mythtv.org/trac/ticket/295>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list