[mythtv-commits] Re: Ticket #341: Music database update does not reread metadata

MythTV mythtv at cvs.mythtv.org
Thu Oct 13 05:16:53 UTC 2005

#341: Music database update does not reread metadata
 Reporter:  eskil <myth at eskil.org>  |        Owner:  ijr
     Type:  patch                   |       Status:  new
 Priority:  minor                   |    Milestone:     
Component:  mythmusic               |      Version:     
 Severity:  medium                  |   Resolution:     
Comment (by Eskil <myth at eskil.org>):

 Attached updated version of the patch, and here's the updated description
 of the changes;

    * Metadata class writes the date_added and date_modified fields to the

    * I've refactored Decoder::getMetadata. It now tries to find the
 metadata in the db, if there's no entry, it call ::readMetadata which does
 the actual read from the file. ::readMetadata call ::doCreateTagger which
 returns a MetaIO object. The various decoders just implement
 ::doCreateTagger to return the right MetaIO object, and they all share
 ::getMetadata, ::readMetadata and ::commitMetadata from the parent.

    * Additionally, ::getMetadata does *not* save the metadata to the db,
 seems like a very undesired sideeffect of a method called "getMetadata".
 main.cpp is now responsible for calling Metadata::dumpToDatabase in
 CheckFile?, and it compares the file's mtime to the date_modified in the

    * progress bars. I've added a MythBusyIndicator 'widget' to
 mythdialogs.h/cpp. It's a QThread that displays a MythProgressDialog and
 does a 'busy spinner' running in the thread. Also changed
 MythProgessDialog slightly to act a 'busy spinner' - it just looks like

    * LCD fixes :
       * added a much needed flush...
       * changed generic screen to have TOP priority, since the only thing
 that uses it is progress meters that block the UI anyway. It was a lower
 priority back in the day since music used the generic screen to show it
 was playing (afaicr), but now there's a dedicated screen for music. If
 it's not top, menu redraws take precedence over a progress and that also
 looks like shit.
       * hacked the generic progress screen so it can show a busy spinner
 with the forementions MythBusyIndicator is running, looks better than the
 QT one...

 Tried to add doxygen comments for all the stuff I've added/methods I've

Ticket URL: <http://svn.mythtv.org/trac/ticket/341>
MythTV <http://www.mythtv.org/>

More information about the mythtv-commits mailing list