[mythtv-commits] Ticket #436: gcc4 compile warnings list & some fixes (not including non-virtual destructor warnings)

[MythTV]

#436: gcc4 compile warnings list & some fixes (not including non-virtual
destructor warnings)
---------------------------------+------------------------------------------
 Reporter:  agforsyth at gmail.com  |       Owner:  ijr 
     Type:  defect               |      Status:  new 
 Priority:  minor                |   Milestone:      
Component:  mythtv               |     Version:  head
 Severity:  low                  |  ---------------------------------+------------------------------------------
 Most of these warning have to do with unused parameters, but a few are
 other things. Two fixes are noted. I thought it would be good to have a
 list.

 In mythtv: [[BR]]
 videoout_xv.cpp:826: warning: unused parameter ‘test_surface’[[BR]]
 mythuiimage.cpp:189: warning: unused parameter ‘clipRect’[[BR]]
 mythuitext.cpp:114: warning: unused parameter ‘clipRect’[[BR]]
 themedmenu.cpp:2299: warning: unused parameter ‘clipRect’[[BR]]
 filter_postprocess.c:57: warning: pointer targets in passing argument 7 of
 ‘pp_postprocess’ differ in signedness[[BR]]
 filldata.cpp:872: warning: ‘chanid’ may be used uninitialized in this
 function[[BR]]
 filldata.cpp:2170: warning: ‘chanid’ may be used uninitialized in this
 function[[BR]]
 filldata.cpp:2170: warning: ‘mplexid’ may be used uninitialized in
 this function[[BR]]

 ----
 To fix filter_postprocess.c: [[BR]]
 edit libs/libavcodec/libpostproc/postprocess.h: [[BR]]
 change #define QP_STORE_T int8_t[[BR]]
 to #define QP_STORE_T uint8_t[[BR]]
 ----

 In mythplugins: [[BR]]
 mythcontrol: [[BR]]
 mythcontrols.cpp:307: warning: unused parameter ‘item’[[BR]]
 mythcontrols.cpp:315: warning: unused parameter ‘item’[[BR]]
 mythcontrols.cpp:351: warning: unused parameter ‘context’[[BR]]

 mythgame: [[BR]]
 rom_metadata.cpp:17: warning: unused parameter ‘RomName’[[BR]]
 rom_metadata.cpp:17: warning: unused parameter ‘GameType’[[BR]]
 rom_metadata.cpp:24: warning: unused parameter ‘CRC32’[[BR]]
 rom_metadata.cpp:24: warning: unused parameter ‘GameTitle’[[BR]]
 rom_metadata.cpp:34: warning: unused parameter ‘CRC32’[[BR]]
 rom_metadata.cpp:34: warning: unused parameter ‘GameTitle’[[BR]]
 rom_metadata.cpp:44: warning: unused parameter ‘CRC32’[[BR]]
 rom_metadata.cpp:44: warning: unused parameter ‘GameTitle’[[BR]]
 rom_metadata.cpp:54: warning: unused parameter ‘CRC32’[[BR]]
 rom_metadata.cpp:54: warning: unused parameter ‘GameTitle’[[BR]]
 rom_metadata.cpp:65: warning: unused parameter ‘CRC32’[[BR]]
 rom_metadata.cpp:65: warning: unused parameter ‘GameTitle’[[BR]]
 rom_metadata.cpp:76: warning: unused parameter ‘CRC32’[[BR]]
 rom_metadata.cpp:76: warning: unused parameter ‘GameTitle’[[BR]]
 rom_metadata.cpp:87: warning: unused parameter ‘CRC32’[[BR]]
 rom_metadata.cpp:87: warning: unused parameter ‘GameTitle’[[BR]]
 rom_metadata.cpp:98: warning: unused parameter ‘CRC32’[[BR]]
 rom_metadata.cpp:98: warning: unused parameter ‘GameTitle’[[BR]]

 mythmusic: [[BR]]
 /usr/include/cdda/cdda_interface.h:195: warning: ‘strerror_tr’ defined
 but not used[[BR]]
 /usr/include/cdda/cdda_interface.h:195: warning: ‘strerror_tr’ defined
 but not used[[BR]]
 /usr/include/cdda/cdda_interface.h:195: warning: ‘strerror_tr’ defined
 but not used[[BR]]
 goom/goom_core.c:659: warning: pointer targets in passing argument 1 of
 ‘tentacle_update’ differ in signedness[[BR]]
 goom/goom_core.c:659: warning: pointer targets in passing argument 2 of
 ‘tentacle_update’ differ in signedness[[BR]]
 goom/goom_core.c:661: warning: pointer targets in passing argument 1 of
 ‘tentacle_update’ differ in signedness[[BR]]
 goom/goom_core.c:661: warning: pointer targets in passing argument 2 of
 ‘tentacle_update’ differ in signedness[[BR]]

 ----
 to fix goom_core.c: [[BR]]
 edit mythmusic/mythmusic/goom/tentacle3d.h: [[BR]]
 change void tentacle_update(int *buf, int *back,[[BR]]
 to void tentacle_update(uint *buf, uint *back,[[BR]]
 ----

-- 
Ticket URL: <http://svn.mythtv.org/trac/ticket/436>
MythTV <http://www.mythtv.org/>
MythTV