[mythtv-commits] Re: Ticket #368: Teletext patch for DVB/IVTV cards

[MythTV]

#368: Teletext patch for DVB/IVTV cards
-----------------------------------------------------+----------------------
 Reporter:  Frank Muenchow (beebof -at- gmx dot de)  |        Owner:  danielk 
     Type:  patch                                    |       Status:  assigned
 Priority:  minor                                    |    Milestone:  0.20    
Component:  mythtv                                   |      Version:  head    
 Severity:  low                                      |   Resolution:          
-----------------------------------------------------+----------------------
Comment (by danielk):

 Looks good, but I don't think I'll be able to review this fully before
 0.19.

 But on a cursory review it looks ok. I did some renaming of functions and
 added some const correctness. The only thing you really have to look at is
 the variables at the
 end of VBIDecoder. These were global and I made them instance variables.

 Also what version of ivtv is needed to test this? I noticed you changed
 the VBI encoding for ivtv. What was the problem with the existing
 encodings? My hope was that old recordings would have decodable
 captions...

-- 
Ticket URL: <http://cvs.mythtv.org/trac/ticket/368>
MythTV <http://www.mythtv.org/>
MythTV