[mythtv-commits] mythtv commits

mythtv at cvs.mythtv.org mythtv at cvs.mythtv.org
Tue May 3 19:00:02 UTC 2005

Changes committed by danielk on Tue May  3 18:58:58 2005

Modified Files:
   in mythtv/libs/libmyth:
   in mythtv/libs/libmythtv:
        NuppelVideoRecorder.cpp RingBuffer.cpp remoteencoder.cpp 
        remoteencoder.h tv_play.cpp tv_rec.cpp tv_rec.h 
   in mythtv/programs/mythbackend:
        encoderlink.cpp encoderlink.h mainserver.cpp 
Log Message:

This removes the next to last exit() call in the myth libraries.
It removes the exit() call in ThreadedFileWriter when an output
file can not be opened (due to permissions problems, space, etc.)

If the file can not be opened the RingBuffer::IsOpen() call will
return false. No change here actually, except we don't no longer
exit the backend before this check could be made. But this does
that we need to check IsOpen() in NVR, and that "SETUP_RING_BUFFER"
can fail, so we now have it return false on failure. Finally, this
means we need to check the result in tv_rec.cpp, and tv_play.cpp.

In the old code the backend would go away leaving the frontend waiting
for a response to the SETUP_RING_BUFFER query.

This isn't a a big change, but I thought I'd explain why 
MYTH_PROTO_VERSION had to change.

The only remaining exit() call in libmyth and libmythtv is in
ThemedMenuPrivate::handleAction(). I'm not sure how one would
go about fixing it without major changes. There are also some
left in mythui code, but I'm assuming there will be a larger
sync with the current MythTV tree to the new UI code.


More information about the mythtv-commits mailing list