[mythtv-commits] mythtv commit: r6965 by danielk

mythtv at cvs.mythtv.org mythtv at cvs.mythtv.org
Sun Jul 31 12:00:55 EDT 2005


      Author: danielk
        Date: 2005-07-31 16:00:55 +0000 (Sun, 31 Jul 2005)
New Revision: 6965
   Changeset: http://cvs.mythtv.org/trac/changeset/6965

Modified:

   trunk/mythtv/libs/libmythtv/avformatdecoder.cpp
   trunk/mythtv/libs/libmythtv/dvbtypes.h
   trunk/mythtv/libs/libmythtv/tv_rec.cpp
   trunk/mythtv/libs/libmythtv/videoout_null.cpp

Log:

While running Valgrind I noticed that
* VideOutputNull does some buffer thrashing on an input change
   This prevented me from discovering that put_pixels_clamped_mmx() in
   dsputil_mmx.cpp was overwriting data way past the end of it's buffers.
* TVRec uses C scratch space improperly when calling localtime()
   This problem was actually causing Valgrind to crash.

These two just caused some spurrious complaints
* DVBTuning doesn't set it's variables to resonable defaults 
  which causes DVBChannel to depend on uninitialized data.
* I didn't initialize the audioSamples array, which makes Valgrind unhappy.
   
This commit fixes these problems.






More information about the mythtv-commits mailing list